[PATCH] D82950: [PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation

[Anil Mahmud via Phabricator via llvm-commits]

anil9 added inline comments.


================
Comment at: lld/ELF/Thunks.cpp:284
+// When the caller requires a valid R2 TOC pointer but the callee does not
+// require a TOC pointer and the callee cannot guaranteee that it doesn't
+// clobber R2 then we need the save R2. This stub does:
----------------
guaranteee - > guarantee


================
Comment at: lld/ELF/Thunks.cpp:285
+// require a TOC pointer and the callee cannot guaranteee that it doesn't
+// clobber R2 then we need the save R2. This stub does:
+// 1) Saves the TOC pointer to the stack.
----------------
need the save -> need to save


================
Comment at: lld/ELF/Thunks.cpp:286
+// clobber R2 then we need the save R2. This stub does:
+// 1) Saves the TOC pointer to the stack.
+// 2) Branch directly to the callee.
----------------
This stub does: -> This stub:


================
Comment at: lld/ELF/Thunks.cpp:287
+// 1) Saves the TOC pointer to the stack.
+// 2) Branch directly to the callee.
+class PPC64R2SaveStub final : public Thunk {
----------------
Branch -> Branches/Jumps


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82950/new/

https://reviews.llvm.org/D82950