[PATCH] D83022: Add option LLVM_NM to allow specifying the location of the llvm-nm tool.
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 2 18:53:46 PDT 2020
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:167
+ set(llvm_nm ${LLVM_NM})
+ set(llvm_nm_target ${LLVM_NM})
endif()
----------------
I guess this works and is a no-op, but setting this variable to empty (or not setting it at all) should also work, I believe, and perhaps expresses the intent clearer (that there's no target for llvm-nm and you're just supplying a prebuilt one).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83022/new/
https://reviews.llvm.org/D83022
More information about the llvm-commits
mailing list