[PATCH] D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPC.h:88-89
+  InstructionSelector *createPPCInstructionSelector(const PPCTargetMachine &,
+                                                    PPCSubtarget &,
+                                                    PPCRegisterBankInfo &);
   namespace PPCII {
----------------
These should be const?


================
Comment at: llvm/lib/Target/PowerPC/PPCInstructionSelector.cpp:39
+  bool select(MachineInstr &I) override;
+  static const char *getName() { return DEBUG_TYPE; }
+
----------------
I'm pretty sure you don't need these and all the other places that override this are dead code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83100/new/

https://reviews.llvm.org/D83100