[PATCH] D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang

[Amy Kwan via Phabricator via llvm-commits]

amyk accepted this revision as: amyk.
amyk added a comment.
This revision is now accepted and ready to land.

I think overall it LGTM.



================
Comment at: clang/lib/Headers/altivec.h:16924
+
+static __inline__ vector signed int __ATTRS_o_ai vec_blendv(
+    vector signed int __a, vector signed int __b, vector unsigned int __c) {
----------------
A minor nit perhaps we should put `vec_blendv` on the next line for consistency, as you put it on the next line in a number of places.


================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1030
+       Intrinsic<[llvm_v16i8_ty], [llvm_v16i8_ty,
+                  llvm_v16i8_ty,llvm_v16i8_ty], [IntrNoMem]>;
+def  int_ppc_vsx_xxblendvh: GCCBuiltin<"__builtin_vsx_xxblendvh">,
----------------
nit: spaces after `,` for the input types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82774/new/

https://reviews.llvm.org/D82774