[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 12:58:06 PDT 2020


arichardson added a comment.

In D78478#2128604 <https://reviews.llvm.org/D78478#2128604>, @MaskRay wrote:

> The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I can't help associating it with Coordinated Universal Time). Adding some folks who may have opinions: @greened @lebedev.ri  @RKSimon @spatel  @xbolva00


I agree that UTC_ARGS could be a bit confusing. However, there are currently 145 UTC_ARGS uses in tests/Transforms and I'd rather not update them as part of this change.

I feel that changing the name should be a separate change that can be committed after this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78478/new/

https://reviews.llvm.org/D78478





More information about the llvm-commits mailing list