[PATCH] D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds

[David Tenty via Phabricator via llvm-commits]

daltenty marked 2 inline comments as done.
daltenty added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:1483
             3, 9, DW_LNE_set_address,
             ValueAndLengths{{0x1234567890abcdef, LineTable::Quad}},
+            "DW_LNE_set_address", None,
----------------
ikudrin wrote:
> jhenderson wrote:
> > It's possible you may have misunderstood what we were suggesting. Rather than adding another argument, I think @ikudrin and I were thinking of changing the `0x1234567890abcdef` to `0x1234567878563412`, and so on in the other tests, so that the error message would be the same regardless of endianness. That way the test is completely agnostic of endianness and there's no need to query the host/target.
> Right, that was the idea.
Yes, I definitely did. This is a much better solution, updated as suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82827/new/

https://reviews.llvm.org/D82827