[PATCH] D82262: [RISCV] Optimize addition with an immediate

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 08:05:43 PDT 2020


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

The patch seems correct to me. I'm not quite sure this is the best place to do the this transformation (guidance on that from other people would be welcome), but I don't have a better solution to propose right now. I'm going to approve this patch, but I suggest you wait a couple more days to give other people an opportunity to comment on that issue.
Regarding the tests, as a nitpicking issue, I would only suggest giving the test functions slightly more semantic names (maybe something like `negative_bound_reject`, etc.).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82262/new/

https://reviews.llvm.org/D82262





More information about the llvm-commits mailing list