[PATCH] D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:12
+// RUN:   -target-cpu pwr10 -triple powerpc64le-unknown-unknown -emit-llvm %s \
+// RUN:   -o - | FileCheck %s -check-prefix=CHECK-LE
+
----------------
I don't see why this is needed as it's the exact same test as line 2 but with a diff check-prefix.


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:186
+  // CHECK-BE: ret <4 x i32>
+  // CHECK-LE: insertelement <4 x i32>
+  // CHECK-LE: ret <4 x i32>
----------------
Why bother with different checks for BE and LE?  Seems they produce the same outputs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82520/new/

https://reviews.llvm.org/D82520