[PATCH] D82979: [AArch64][SVE] NFC: Rename isOrig -> isReverseInstr
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 2 04:48:23 PDT 2020
paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:448
+ // e.g. DIV -> DIVR
if (AArch64::getSVERevInstr(Opcode) != -1)
Opcode = AArch64::getSVERevInstr(Opcode);
----------------
Not the fault of this patch but we might want to consider something like below, unless we're confident there won't actually be a double lookup.
```
if ((int RevOpcode = AArch64::getSVERevInstr(Opcode)) != -1)
Opcode = RevOpcode;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82979/new/
https://reviews.llvm.org/D82979
More information about the llvm-commits
mailing list