[PATCH] D82780: [AArch64][SVE] Put zeroing pseudos and patterns under flag.

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 04:48:17 PDT 2020


paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:2284-2285
+  let Predicates = [HasSVE2, UseExperimentalZeroingPseudos] in {
+    defm SQSHL_ZPZI  : sve_int_bin_pred_shift_imm_left_zeroing_bhsd<null_frag>;
+    defm UQSHL_ZPZI  : sve_int_bin_pred_shift_imm_left_zeroing_bhsd<null_frag>;
+    defm SRSHR_ZPZI  : sve_int_bin_pred_shift_imm_right_zeroing_bhsd<int_aarch64_sve_srshr>;
----------------
sdesmalen wrote:
> paulwalker-arm wrote:
> > Given the use of null_frag, do these entries do anything useful?
> They don't, but their name was already used in the multiclass above, so I thought it made sense to define the Pseudos but not have them match in any patterns yet.
I guess it won't be redundant for long once the zeroing is fleshed out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82780/new/

https://reviews.llvm.org/D82780





More information about the llvm-commits mailing list