[PATCH] D82721: [ScalarEvolution] createSCEV(): recognize `udiv`/`urem` disguised as an `sdiv`/`srem`

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 02:38:25 PDT 2020


lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

In D82721#2126986 <https://reviews.llvm.org/D82721#2126986>, @efriedma wrote:

> LGTM


Thank you for the review!



================
Comment at: llvm/test/Analysis/ScalarEvolution/sdiv.ll:17
 ; CHECK-NEXT:    %rem = sdiv i32 %i.0, 2
-; CHECK-NEXT:    --> (zext i1 {false,+,true}<%for.cond> to i32) U: [0,2) S: [0,2) Exits: (zext i1 (trunc i32 %width to i1) to i32) LoopDispositions: { %for.cond: Computable }
 ; CHECK-NEXT:    %idxprom = sext i32 %rem to i64
----------------
efriedma wrote:
> clementval wrote:
> > lebedev.ri wrote:
> > > efriedma wrote:
> > > > What are you diffing against here?
> > > Didn't push the test commit originally.
> > > Now done: rG51ff7642a33f73518d60909e3fe4e6348dcc7b27.
> > This commit is making a bunch of builedbot failing. Can you revert it?
> Oh, that makes more sense.
Yeah, somehow i ended up with wrong initial check lines, and didn't notice it, oops.
Sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82721/new/

https://reviews.llvm.org/D82721





More information about the llvm-commits mailing list