[PATCH] D81939: [deadargelim] Attach dbg info to the insert/extractvalue instructions

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked 3 inline comments as done.
djtodoro added inline comments.


================
Comment at: llvm/test/Transforms/DeadArgElim/multdeadretval.ll:12
+; DEBUG: %oldret = extractvalue { i16, i32 } %B, 1, !dbg
+; DEBUG: %oldret = extractvalue { i32, i16 } %B, 0, !dbg
+; DEBUG: %oldret = insertvalue { i16, i32 } undef, i32 %ret, 1, !dbg
----------------
aprantl wrote:
> Thanks!
> 
> Should we also check that the !dbg attachment is the same as some other instruction? Or are we really fine with just *any* !dbg location?
It makes sense to me to test the actual locations. I've addressed that as well. Thanks you @aprantl!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81939/new/

https://reviews.llvm.org/D81939