[PATCH] D82980: [NFC] Run clang-format on llvm-objcopy.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 23:57:28 PDT 2020
jhenderson added a comment.
No issue in principle with this, but we do need to figure out the canonical version of clang-format we want to use for this if we are going to do it. I have no personal opinion on it, but suspect my installed clang-format version is out-of-date, and that if I were to do the same thing you did I'd get different results.
================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:210
if (Split.second.getAsInteger(0, NewAlign))
- return createStringError(errc::invalid_argument,
- "invalid alignment for --set-section-alignment: '%s'",
- Split.second.str().c_str());
+ return createStringError(
+ errc::invalid_argument,
----------------
MaskRay wrote:
> I suspect the difference is due to changed heuristics of clang-format (of different versions).
Actually, I suspect it just wasn't formatted before - the "invalid argument for..." string below in the original is over the 80 character limit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82980/new/
https://reviews.llvm.org/D82980
More information about the llvm-commits
mailing list