[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:294
+  // Byte 2
+  static constexpr uint32_t LanguageIdMask = 0xFF0000;
+  static constexpr uint8_t LanguageIdShift = 16;
----------------
I'd much prefer if the mask literals have the number of hex digits that the type of the mask implies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585