[PATCH] D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC)

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 20:35:34 PDT 2020


mehdi_amini marked 12 inline comments as done.
mehdi_amini added inline comments.


================
Comment at: llvm/docs/CodingStandards.rst:1657
+  if (auto *D = dyn_cast<FunctionDecl>(D)) {
+    if(shouldProcess(D))
+      handleVarDecl(D);
----------------
lattner wrote:
> MaskRay wrote:
> > Add a space after `if`
> and after the for.  Also, I'd recommend using size_t instead of 'int', and != instead of <.  
Why the `size_t` here? I thought best practice was rather to write for loops with `int`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82594/new/

https://reviews.llvm.org/D82594





More information about the llvm-commits mailing list