[PATCH] D83017: [WebAssembly] Do not omit range checks for i64 switches

Alon Zakai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 18:54:47 PDT 2020


kripken added a comment.

It looks like this pattern-matches on the switch's input. Does that mean that if we see a valid wrap there, we would also optimize this less?

That is, the invalid case is

switch (value64) { .. }

but a valid case is

switch (int32_t(value64)) { .. }

i.e. if there is a wrap that the user wrote, it's a valid wrap and we don't need a bounds check, as opposed to an "internal" wrap added by LLVM's codegen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83017/new/

https://reviews.llvm.org/D83017





More information about the llvm-commits mailing list