[PATCH] D82826: [X86] support .nops directive
Jian Cai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 18:23:10 PDT 2020
jcai19 added a comment.
In D82826#2126955 <https://reviews.llvm.org/D82826#2126955>, @nickdesaulniers wrote:
> I'm having trouble posting comments inline; it seems fabricator won't allow me to "save" comments.
>
> Is it too painful to make the member of `MCNopsFragment` `uint64_t`? a la `MCStreamer::emitFill`
I suppose it's easy to do but I'll have to explicitly cast them to signed integers to check if they are smaller than 0. That is probably more error-prone IMO. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82826/new/
https://reviews.llvm.org/D82826
More information about the llvm-commits
mailing list