[PATCH] D82906: [flang][openmp] Use common Directive and Clause enum from llvm/Frontend

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D82906#2126684 <https://reviews.llvm.org/D82906#2126684>, @dblaikie wrote:

> In D82906#2126543 <https://reviews.llvm.org/D82906#2126543>, @clementval wrote:
>
> > In D82906#2126444 <https://reviews.llvm.org/D82906#2126444>, @ymandel wrote:
> >
> > > Seems like this is causing a slew of compilation warnings, like:
> > >
> > >   [745/3847] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaConcept.cpp.o
> > >   In file included from /usr/local/google/home/yitzhakm/remote-build/llvm-git/llvm-project/clang/lib/Sema/SemaConcept.cpp:24:
> > >   /usr/local/google/home/yitzhakm/remote-build/llvm-git/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:2994:14: warning: enumeration values 'OMPC_inbranch', 'OMPC_link', and 'OMPC_notinbranch' not handled in switch [-Wswitch]
> > >     switch (C->getClauseKind()) {
> > >                ^
> > >   1 warning generated.
> > >   [766/3847] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseOpenMP.cpp.o
> > >   /usr/local/google/home/yitzhakm/remote-build/llvm-git/llvm-project/clang/lib/Parse/ParseOpenMP.cpp:1689:11: warning: 19 enumeration values not handled in switch: 'OMPD_distribute_parallel_do', 'OMPD_distribute_parallel_do_simd', 'OMPD_do'
> > >   ... [-Wswitch]
> > >     switch (DKind) {
> > >             ^
> > >   /usr/local/google/home/yitzhakm/remote-build/llvm-git/llvm-project/clang/lib/Parse/ParseOpenMP.cpp:2078:11: warning: 19 enumeration values not handled in switch: 'OMPD_distribute_parallel_do', 'OMPD_distribute_parallel_do_simd', 'OMPD_do'
> > >   ... [-Wswitch]
> > >     switch (DKind) {
> > >             ^
> > >
> >
> >
> > Yes, sorry for that. I'm working on a fix to handle newly introduce directives/clauses. Should be ok tonight.
>
>
> If a fix is going to take more than a few minutes (a few hours/the rest of the day is pretty high) could you revert this patch & recommit with the fixes?


I reverted it. Will commit back later today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82906/new/

https://reviews.llvm.org/D82906