[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

[Nathan James via Phabricator via llvm-commits]

njames93 marked 5 inline comments as done.
njames93 added inline comments.


================
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:124
+llvm::Optional<llvm::Regex::RegexFlags> getRegexFlag(llvm::StringRef Flag) {
+  for (auto &StringFlag : RegexMap) {
+    if (Flag == StringFlag.first)
----------------
aaron.ballman wrote:
> `const auto &` (same below)
Foiled by my own check ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82706/new/

https://reviews.llvm.org/D82706