[PATCH] D82883: [LLD][COFF] Deduplicate .pdata entries

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Just curious - do you know why you end up with duplicates? In most cases where there could be duplicates, they should be in a comdat section where only one is picked? And if not, you'd have a duplicate definition of a symbol in the corresponding text section - right?



================
Comment at: lld/COFF/Writer.cpp:1869
+    // the PE image, but that should be fine.
+    memset(end - removed, 0, removed * sizeof(Entry));
+
----------------
Would it be possible to adjust the virtual size of the .pdata section as well, to exclude the pruned bits? I could imagine that some runtime introspection tools locate the section directly instead of using the data directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82883/new/

https://reviews.llvm.org/D82883