[PATCH] D82987: [BasicAA] Fix recursive phi MustAlias calculations

[Dave Green via Phabricator via llvm-commits]

dmgreen marked an inline comment as done.
dmgreen added a comment.

In D82987#2126204 <https://reviews.llvm.org/D82987#2126204>, @efriedma wrote:

> Commit message uses "NoAlias" where it means to use "MayAlias"?


Whoops. Yeah. MayAlias was what it was meant to say.



================
Comment at: llvm/test/Analysis/BasicAA/recphi.ll:8
 ; CHECK:         NoAlias:      float* %next, float* %src1
-; CHECK:         NoAlias:      float* %next, float* %src2
+; CHECK:         MayAlias:     float* %next, float* %src2
 ; CHECK:         NoAlias:      float* %next, float* %phi
----------------
efriedma wrote:
> `NoAlias:      float* %next, float* %src2` is actually correct; not sure how hard it would be to prove, though.
Yep. I left this test in because it does show it's not always better. Like you said I'm not sure how to prove that though. It might start to need something like SCEVAA. (Although in this case with the noalias - maybe it could be simpler than that).

I would like to turn this option on by default and these would all be better than (or equal) to current trunk, at least.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82987/new/

https://reviews.llvm.org/D82987