[PATCH] D82660: [RISCV] Optimize multiplication by specific immediates

[Sam Elliott via Phabricator via llvm-commits]

lenary added a comment.

This is looking good.

I'm going to pre-commit the test additions today - if you could rebase your changes on top, that will allow us to see how this change affects the new testcases you added. I'll keep you as the author and let you know the sha so you can rebase on top of the commit.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2989
+
+  // TODO: Check vector types.
+  return false;
----------------
This TODO should not apply to RISC-V, yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82660/new/

https://reviews.llvm.org/D82660