[PATCH] D82816: [LLD][PowerPC] Implement R_PPC64_REL24_NOTOC calls, callee also has no TOC

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 13:32:08 PDT 2020


stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.

I had a minor nit. 
Otherwise I think this is fine.
LGTM.

However, please wait for approval from sfertile or MaskRay before committing.



================
Comment at: lld/ELF/Arch/PPC64.cpp:1039
+  if (type != R_PPC64_REL14 && type != R_PPC64_REL24
+      && type != R_PPC64_REL24_NOTOC)
     return false;
----------------
nit:
Format code as clang-format says makes sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82816/new/

https://reviews.llvm.org/D82816





More information about the llvm-commits mailing list