[PATCH] D82923: introducing llvm-libtool
James Y Knight via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 12:27:14 PDT 2020
jyknight added a comment.
I suggest removing the extraneous level of directory "Darwin" -- just put the files in "llvm/tools/llvm-libtool-darwin", name the source "llvm-libtool-darwin.cpp", and say you're adding "llvm-libtool-darwin" in the commit message.
While it's weird to have a darwin-specific tool for creating archives and shared libraries, that's the status quo. And moving that to an LLVM implementation is entirely reasonable. Let's just not pretend this is ever going to be something else other than that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82923/new/
https://reviews.llvm.org/D82923
More information about the llvm-commits
mailing list