[PATCH] D82903: [flang] Bug fix for ambiguous references to data and functions

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld marked an inline comment as done.
PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:6300
+    if (const parser::Name * name{std::get_if<parser::Name>(&elem.base.u)}) {
+      resolver_.NoteExecutablePartArrayElement(*name);
+    }
----------------
tskeith wrote:
> Do you have an example where this is needed?
You're right.  It's not needed!  Eliminating it has the result of always causing references to functions being recognized before references to array elements.  This changes the error messages where the array reference precedes the function reference, but I think that's OK.  I'll get rid of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82903/new/

https://reviews.llvm.org/D82903