[PATCH] D82872: [CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM with nit addressed.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:20270
+
+  // We currently only perform this optimisation for fixed length vectors as
+  // the code assumes we know the vector length. In theory, we could do
----------------
nit: This comment does the opposite of clarifying things for me. Maybe better to just remove it, as the suggestion is quite speculative anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82872/new/

https://reviews.llvm.org/D82872