[PATCH] D79635: [RISCV] Split the pseudo instruction splitting pass

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

In D79635#2125714 <https://reviews.llvm.org/D79635#2125714>, @luismarques wrote:

> Sam was saying that (as far as he could remember from the top of his head) that we have labels that point to places that might not be the start of an IR BB, so they didn't always have LLVM block names, and this had been previously been addressed by one of Lewis' patches, adding checks like `!MBB->hasAddressTaken() && !MBB->hasLabelMustBeEmitted()`, but that these checks might not have been added in all places where they were needed, or something along those lines. I'll will delve into this when possible (but if someone wants to have a shot at this let me know).


Should these blocks just be manually split, that way you don't have to hack around tracking that an arbitrary instruction in the stream is a branch target?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79635/new/

https://reviews.llvm.org/D79635