[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 09:10:23 PDT 2020


lxfind added a comment.

In D82314#2124662 <https://reviews.llvm.org/D82314#2124662>, @junparser wrote:

> In D82314#2124661 <https://reviews.llvm.org/D82314#2124661>, @junparser wrote:
>
> > @lxfind This patch causes some mismatch when variable is used in both resume and destroy function. Besides, we should move this patch and the check in buildCoroutineFrame.
>
>
> @lxfind, Would you try to fix this? If you do not have time, then I'll try do this. Thanks


Could you please help take a look, if you have a local repro? Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82314/new/

https://reviews.llvm.org/D82314





More information about the llvm-commits mailing list