[PATCH] D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang

[Lei Huang via Phabricator via llvm-commits]

lei added a comment.

p10-permute-ops.ll => builtins-ppc-p10permute.ll
Looks like this file is being created in several diff patches you have up for review.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:738
+  def : Pat<(v16i8 
+            (int_ppc_vsx_xxpermx v16i8:$A, v16i8:$B, v16i8:$C , timm:$D)),
+            (COPY_TO_REGCLASS (XXPERMX (COPY_TO_REGCLASS $A, VSRC),
----------------
nit: indentation is off


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:742
+            VSRC)>;
+}
+
----------------
Looks like you are creating is block in several other patches you have up for review.  Can you please make sure when rebasing after they get comitted to make sure you are added these new patters into the same predicate block rather then creating a new one each time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82869/new/

https://reviews.llvm.org/D82869