[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.
Ferran Pallarès Roca via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 06:28:11 PDT 2020
fpallares added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2367
+ Opcode == RISCV::VADC_VIM || Opcode == RISCV::VSBC_VVM ||
+ Opcode == RISCV::VSBC_VXM) {
+ if (DestReg == RISCV::V0)
----------------
I think we might not need to treat `vadc` and `vsbc` specially here. Since those have 4 operands they should fall on the `else` branch of the next `if-else` block:
```
if (Inst.getNumOperands() == 4)
CheckReg = Inst.getOperand(3).getReg();
```
And that should produce the expected result. Did I miss some other reason why those should be treated separately?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80802/new/
https://reviews.llvm.org/D80802
More information about the llvm-commits
mailing list