[PATCH] D82955: [llvm-readelf] - Do not error out when dumping symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 06:28:06 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

When the --symbols option/--dyn-symbols is given we might report an
error and exit when something goes not right. E.g. when the SHT_SYMTAB
section is broken. Though we could report a warning and try to continue
dumping instead in many cases.

This patch removes `unwrapOrErr` calls from the code involved in the
flow described.


https://reviews.llvm.org/D82955

Files:
  llvm/test/Object/invalid.test
  llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
  llvm/test/tools/llvm-readobj/ELF/symbols.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82955.274779.patch
Type: text/x-patch
Size: 15714 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200701/2e9c4b18/attachment.bin>


More information about the llvm-commits mailing list