[PATCH] D71786: RFC: [Support] On Windows, add optional support for rpmalloc

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 04:49:30 PDT 2020


russell.gallop added a comment.

In D71786#2124872 <https://reviews.llvm.org/D71786#2124872>, @hans wrote:

> I also don't know what exactly the policy around third_party code is, so discussing this on llvm-dev is probably a good idea.
>
> But perhaps one way of side-stepping the whole issue would be to not check in rpmalloc into LLVM, but make the user point at it if they want to use it through a cmake variable, e.g. -DLLVM_USE_RPMALLOC=c:\path\to\rpmalloc (if such a thing is technically practical, I don't know)


That sounds like @aganea's suggestion from https://reviews.llvm.org/D71786#2123378.

Maybe it be worth putting that approach up in a separate review (as it's quite different).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786





More information about the llvm-commits mailing list