[PATCH] D82933: [DWARFYAML][debug_abbrev] Emit 0 byte for terminating abbreviations.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 02:39:51 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with on suggestion.
================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml:46-47
+# CONTENT-NEXT: 0020: CEC2F105 000000 |.......|
+## ^------- Value SLEB128 (12345678) ^--- terminating entry for attributes.
+## ^- terminating entry for abbreviations.
# CONTENT-NEXT: )
----------------
How about "attr terminator" and "abbrev terminator".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82933/new/
https://reviews.llvm.org/D82933
More information about the llvm-commits
mailing list