[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.
Roger Ferrer Ibanez via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 01:35:25 PDT 2020
rogfer01 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:796
}
return "";
}
----------------
Minor nit that we missed in the patch of 0.8: can you replace this return with
```lang=cpp
llvm_unreachable();
```
as recommended in the second paragraph of https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
Ditto in `getSEWStr` above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80802/new/
https://reviews.llvm.org/D80802
More information about the llvm-commits
mailing list