[PATCH] D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 01:35:24 PDT 2020
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with one minor
================
Comment at: llvm/lib/CodeGen/ScalarizeMaskedMemIntrin.cpp:523
assert(isa<VectorType>(Src->getType()) &&
"Unexpected data type in masked scatter intrinsic");
----------------
I know you're being cautious about changes but I think this assertion can use isa<FixedVectorType>? Or drop the assert entirely - cast<> implicitly asserts for the correct type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82210/new/
https://reviews.llvm.org/D82210
More information about the llvm-commits
mailing list