[PATCH] D81675: SILoadStoreOptimizer: add support for GFX10 image instructions

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 01:02:49 PDT 2020


piotr added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/merge-image-load.mir:2
 # RUN: llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs -run-pass si-load-store-opt -o - %s | FileCheck -check-prefix=GFX9 %s
+# RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs -run-pass si-load-store-opt -o - %s | FileCheck -check-prefix=GFX9 %s
 
----------------
foad wrote:
> These tests pass with -mcpu=gfx1010 but I don't think they're really testing anything useful. Do I need to regenerate them using gfx10-specific image sample opcodes or something?
Yes, it would be good if you could add tests for image instructions with NSA.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81675/new/

https://reviews.llvm.org/D81675





More information about the llvm-commits mailing list