[PATCH] D80860: Exact integer emptiness checks for FlatAffineConstraints

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula accepted this revision.
bondhugula added inline comments.


================
Comment at: mlir/unittests/Analysis/AffineStructuresTest.cpp:64
+
+/// We don't implement Vector of Vectors to ArrayRef of ArrayRefs since that
+/// would necessitate worrying about possible dangling references.
----------------
bondhugula wrote:
> arjunp wrote:
> > Is there a better way? This is needed since we moved to ArrayRefs for arguments but in `checkPermutationsSample` below we need to pass SmallVectors of SmallVectors to `makeFACFromConstraints`.
> We don't need to switch to ArrayRef of ArrayRef if you have SmallVector of SmallVector, but only to ArrayRef of SmallVector.
I actually meant `ArrayRef<SmallVector,...>` as the function argument instead of `SmallVector<SmallVector<...`. Make sure you don't run into underlying storage lifetime issues. `ArrayRef<SmallVector..>` should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80860/new/

https://reviews.llvm.org/D80860