[PATCH] D82922: [NewPM] Add explicit init value to -enable-new-pm

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 30 23:15:06 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/opt/opt.cpp:75
+static cl::opt<bool> EnableNewPassManager(
+    "enable-new-pm", cl::desc("Enable the new pass manager"), cl::init(false));
 
----------------
aeubanks wrote:
> MaskRay wrote:
> > false is the default value so this appears to be NFC...
> I can more easily change the default value to true and test this way.
> If there is a better way I'd like to know.
Adding/removing `cl::init(true)` is very straightforward. Why is this NFC change needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82922/new/

https://reviews.llvm.org/D82922





More information about the llvm-commits mailing list