[PATCH] D78434: [mlir] resolve types from attributes in assemblyFormat

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:1777
+    return arg;
+  if (auto *attr = findSeenAttr(name))
+    return attr;
----------------
Can you name the types instead of `auto`? (when the type isn't immediately obvious and/or it does not improve readability significantly)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78434/new/

https://reviews.llvm.org/D78434