[PATCH] D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions.

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1477
+  case PPCISD::XXSPLTI_SP_TO_DP:
+    return "PPCISD::XXSPLTI_SP_TO_DP";
   case PPCISD::VECINSERT:       return "PPCISD::VECINSERT";
----------------
Any reason why we are not following the format used for the other case statements?  
If it fit within 1 line, it would be good to match the formate of this switch stmt.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:708
+                                      [(set v2f64:$XT,
+				             (PPCxxspltidp i32:$IMM32))]>;
   def XXSPLTI32DX :
----------------
nit: indentation is off.


================
Comment at: llvm/test/CodeGen/PowerPC/power10-immediate-moves-and-splats.ll:4
+; RUN:     -ppc-asm-full-reg-names -mcpu=pwr10 < %s | FileCheck %s \
+; RUN:     --check-prefix=CHECK-P10
+
----------------
Do we need BE run line here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82911/new/

https://reviews.llvm.org/D82911