[llvm] df1f371 - [SVE] Reject vector struct indexes for scalable vectors.

[Eli Friedman via llvm-commits]

Author: Eli Friedman
Date: 2020-06-30T13:52:38-07:00
New Revision: df1f371e28301a046b734ed1b8be0f07253700e2

URL: https://github.com/llvm/llvm-project/commit/df1f371e28301a046b734ed1b8be0f07253700e2
DIFF: https://github.com/llvm/llvm-project/commit/df1f371e28301a046b734ed1b8be0f07253700e2.diff

LOG: [SVE] Reject vector struct indexes for scalable vectors.

It's messy to pattern-match, and completely unnecessary: scalar indexes
work equally well.

See also discussion on D81620 and D82061.

Differential Revision: https://reviews.llvm.org/D82430

Added: 
    llvm/test/Assembler/getelementptr_vscale_struct.ll

Modified: 
    llvm/lib/IR/Type.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/IR/Type.cpp b/llvm/lib/IR/Type.cpp
index bb077c1fd019..d869a6e07cca 100644
--- a/llvm/lib/IR/Type.cpp
+++ b/llvm/lib/IR/Type.cpp
@@ -548,6 +548,8 @@ bool StructType::indexValid(const Value *V) const {
   // vector case all of the indices must be equal.
   if (!V->getType()->isIntOrIntVectorTy(32))
     return false;
+  if (isa<ScalableVectorType>(V->getType()))
+    return false;
   const Constant *C = dyn_cast<Constant>(V);
   if (C && V->getType()->isVectorTy())
     C = C->getSplatValue();

diff  --git a/llvm/test/Assembler/getelementptr_vscale_struct.ll b/llvm/test/Assembler/getelementptr_vscale_struct.ll
new file mode 100644
index 000000000000..c6b592c0bf8b
--- /dev/null
+++ b/llvm/test/Assembler/getelementptr_vscale_struct.ll
@@ -0,0 +1,10 @@
+; RUN: not llvm-as < %s >/dev/null 2> %t
+; RUN: FileCheck %s < %t
+; Test that a scalable vector struct index is rejected.
+
+; CHECK: invalid getelementptr indices
+
+define <vscale x 2 x i32*> @test7(<vscale x 2 x {i32, i32}*> %a) {
+  %w = getelementptr {i32, i32}, <vscale x 2 x {i32, i32}*> %a, <vscale x 2 x i32> zeroinitializer, <vscale x 2 x i32> zeroinitializer
+  ret <vscale x 2 x i32*> %w
+}