[PATCH] D82884: [lld][WebAssembly] Give better error message on bad archive member

Tue Jun 30 13:36:06 PDT 2020

sbc100 marked an inline comment as done.
sbc100 added inline comments.

================
Comment at: lld/test/wasm/lto/incompatible.ll:12
 ; CHECK: {{.*}}incompatible.ll.tmp.bc: machine type must be wasm32
+; CHECK-ARCHIVE: wasm-ld: error: {{.*}}.a(incompatible.ll.tmp.bc): machine type must be wasm32
----------------
sbc100 wrote:
> dschuff wrote:
> > so this has to be a wildcard `{{.*}}.a` and can't be something like `%t.a`? I guess because there's no way to get the basename?
> > 
> > Also: should there be a space between the `.a` and the `(`?
> I'll try just `%t.a`.   
> 
> No space between archive name and open paren, no.
Actually you can't use %t in check pattern.. would need to pass extra args to FileCheck.  I'm inclined to leave this as is.. since it fits with the existing tests and covers what we really care about here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82884/new/

https://reviews.llvm.org/D82884