[PATCH] D82872: [CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 30 13:04:01 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:20277
+  if (InVal.getOpcode() == ISD::EXTRACT_VECTOR_ELT &&
+      InVal->getOperand(0).getValueType().isFixedLengthVector()) {
     SDValue InVec = InVal->getOperand(0);
----------------
Do we not need to check the result type of the SCALAR_TO_VECTOR node itself?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82872/new/

https://reviews.llvm.org/D82872





More information about the llvm-commits mailing list