[PATCH] D81784: [ELF] Resolve relocations in .debug_* referencing (discarded symbols or ICF folded section symbols) to tombstone values

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D81784#2122721 <https://reviews.llvm.org/D81784#2122721>, @jhenderson wrote:

> Whilst trying to create a small fix locally, I noticed that our downstream test was originally motivated by a R_X86_64_DTPOFF32 relocation rather than a 64-bit one, since the DWARF was using a 4-byte location offset in this case. I guess we need to allow both these relocation types to follow the same code path as R_X86_64_64. At that point, I start to wonder whether we should just allow all relocation types to follow that path...


I agree that R_X86_64_DTPOFF{32,64} (R_DTPREL) should use -1 as well, but I don't think R_X86_64_32 should use it (tested in `debug-dead-reloc-32.s`)

Created D82899 <https://reviews.llvm.org/D82899>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81784/new/

https://reviews.llvm.org/D81784