[PATCH] D82896: [PowerPC][Power10] Add Vector Splat Immediate, Permute, Blend, Shift Double Bit immediate Instruction Definitions and MC Tests

[Lei Huang via Phabricator via llvm-commits]

lei accepted this revision as: lei.
lei added a comment.
This revision is now accepted and ready to land.

LGTM other then the minor nit that can be address on commit.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:331
+
+class 8RR_XX4_XTABC6<bits<6> opcode, bits<2> xo, dag OOL, dag IOL,
+                     string asmstr, InstrItinClass itin, list<dag> pattern>
----------------
nit... wondering if we can reorder this 2 class def so its:

```
class 8RR_XX4_XTABC6
....
class 8RR_XX4_IMM3_XTABC6
...
```
Seems like the class defined on line 180 `class 8RR_XX4Form_IMM8_XTAB6` should of been named `class 8RR_XX4Form_IMM8_XTABC6`?

If so it would be good if these are defined in order.
What's the diff in `XX4` vs `XX4Form` in the naming?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82896/new/

https://reviews.llvm.org/D82896