[PATCH] D82463: [AMDGPU] Spill more than wavesize CSR SGPRs

[Saiyedul Islam via Phabricator via llvm-commits]

saiislam marked an inline comment as done.
saiislam added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/spill_more_than_wavesize_csr_sgprs.ll:31
+  %alloca = alloca i32, align 4, addrspace(5)
+  store volatile i32 0, i32 addrspace(5)* %alloca
+  call void asm sideeffect "",
----------------
arsenm wrote:
> saiislam wrote:
> > With this patch applied over recent trunk, I am seeing following behavior:
> > 
> >   - without volatile in store instruction, correct behavior (using next vgpr for spilling). stack object instruction gets optimized out
> >   - with volatile in store instruction, spills are still getting overwritten
> >   - With -O0, with and without volatile spills are getting overwritten.
> > 
> > So, whenever stack object is present, wrong behavior is getting triggered somehow.
> Did you mean without the patch?
No, I mean with the patch. Something changed in last 3-4 days.
Earlier, this patch used to work correctly for volatile store instruction as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82463/new/

https://reviews.llvm.org/D82463