[PATCH] D82438: [SimplifyCFG] Cost required selects

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1994
 /// \returns true if the conditional block is removed.
 bool SimplifyCFGOpt::SpeculativelyExecuteBB(BranchInst *BI, BasicBlock *ThenBB,
                                             const TargetTransformInfo &TTI) {
----------------
lebedev.ri wrote:
> I do not understand what is going on in this function.
> Why are we comparing each separate cost with threshold,
> instead of accumulating the costs and comparing that?
Hmm, I hadn't noticed that. Certainly happy to look into that next.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82438/new/

https://reviews.llvm.org/D82438