[PATCH] D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds

[David Tenty via Phabricator via llvm-commits]

daltenty added a comment.

In D82827#2122013 <https://reviews.llvm.org/D82827#2122013>, @jhenderson wrote:

> In D82827#2121798 <https://reviews.llvm.org/D82827#2121798>, @ikudrin wrote:
>
> > The patch looks appropriate, but now I think that maybe it would have been enough to simply use symmetrical constants for these particular tests?
>
>
> Testing endianness behaviour of the code under test is not what the original change was about, so getting rid of this byte-swapping code entirely would make the testing simpler, I agree. @daltenty, are you happy to do that? It should be a fairly straightforward change, I believe.


That makes sense to me, I will update to remove the byteswap and add a set of symmetrical constants for the big-endian case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82827/new/

https://reviews.llvm.org/D82827