[PATCH] D82858: [llvm-objdump] Detect note section for ELF objects

[Ronak Chauhan via Phabricator via llvm-commits]

rochauha marked an inline comment as done.
rochauha added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1312
+      outs() << "\n.note section : Pending support\n";
+      continue;
+    }
----------------
jhenderson wrote:
> I'm not sure it's advisable to skip printing the bytes. The current behaviour will cause the section data to be printed with --disassemble-all; this patch prevents that, meaning that until you implement the support, the section contents won't be dumped, which is a regression.
Would it be a good idea to just print `.note section : Pending support` right now and falling back to the normal flow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82858/new/

https://reviews.llvm.org/D82858