[PATCH] D82858: [llvm-objdump] Detect note section for ELF objects

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Could you more clearly clarify what the motivation here is? Is this working towards some missing GNU compatibility or similar? If so, could you paste an example of what GNU objdump produces, please.

Note that .note sections can be dumped using llvm-readelf in GNU style, just not as part of the disassembly.



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1312
+      outs() << "\n.note section : Pending support\n";
+      continue;
+    }
----------------
I'm not sure it's advisable to skip printing the bytes. The current behaviour will cause the section data to be printed with --disassemble-all; this patch prevents that, meaning that until you implement the support, the section contents won't be dumped, which is a regression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82858/new/

https://reviews.llvm.org/D82858